Skip to content

arch/x86: Fixed FCLEX/FNCLEX, FCMOVcc, etc... instructions not parse#7

Open
pdegama wants to merge 1 commit intogolang:masterfrom
pdegama:x86_march_2023_manual
Open

arch/x86: Fixed FCLEX/FNCLEX, FCMOVcc, etc... instructions not parse#7
pdegama wants to merge 1 commit intogolang:masterfrom
pdegama:x86_march_2023_manual

Conversation

@pdegama
Copy link

@pdegama pdegama commented Apr 16, 2023

Fixed FCLEX/FNCLEX, FCMOVcc, FPATAN, INVD, INVLPG, LOCK, OUT, OUTS/OUTSB/OUTSW/OUTSD, PUSH, RCL/RCR/ROL/ROR, RDMSR, SAL/SAR/SHL/SHR, SGDT, and SIDT instructions in Intel Instruction Set Reference golang/go#325383-079US, March 2023 is not parse

@pdegama
arch/x86: Fixed FCLEX/FNCLEX, FCMOVcc, etc... instructions not parse
cdec853 
Fixed FCLEX/FNCLEX, FCMOVcc, FPATAN, INVD, INVLPG, LOCK, OUT,
OUTS/OUTSB/OUTSW/OUTSD, PUSH, RCL/RCR/ROL/ROR, RDMSR, SAL/SAR/SHL/SHR,
SGDT, and SIDT instructions in Intel Instruction Set
Reference golang/go#325383-079US, March 2023 is not parse

Change-Id: I609c12731ec170fb2d04562aa45956b2e22b88e4
@pdegama pdegama closed this Apr 16, 2023
@pdegama pdegama reopened this Apr 16, 2023
@gopherbot
Copy link
Contributor

gopherbot commented Apr 16, 2023

This PR (HEAD: cdec853) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/arch/+/484955 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Apr 16, 2023

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 16, 2023

Message from Parthka:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 16, 2023

Message from Parthka:

Patch Set 1: -Code-Review

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 16, 2023

Message from Parthka:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 18, 2023

Message from Cherry Mui:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 18, 2023

Message from Cherry Mui:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 18, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Apr 18, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Sep 25, 2023

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Sep 25, 2023

Message from Parthka:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Sep 25, 2023

Message from Parthka:

Patch Set 1: -Code-Review

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Sep 25, 2023

Message from Parthka:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Sep 25, 2023

Message from Cherry Mui:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Sep 25, 2023

Message from Cherry Mui:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Sep 25, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Sep 25, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/484955.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pdegama @gopherbot